From 351c3531a932b30ad42d144b344edd23c1693559 Mon Sep 17 00:00:00 2001 From: Paul Duncan Date: Sat, 5 Feb 2022 11:18:10 -0500 Subject: dbstore/dbstore.go: add comment about weird result set error handling --- dbstore/dbstore.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dbstore/dbstore.go b/dbstore/dbstore.go index 7f22f3b..0ab6fcf 100644 --- a/dbstore/dbstore.go +++ b/dbstore/dbstore.go @@ -196,6 +196,10 @@ func (me DbStore) CpeSearch( } // close rows + // FIXME: is this correct? i am following the example from the + // database/sql documentation, but it is messy and it seems + // counterintuitive to close the row set and then do an additional + // test for iteration errors... if err = rows.Close(); err != nil { return r, err } -- cgit v1.2.3